On Thu, 16 Mar 2023 09:03:36 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> test/jdk/tools/jpackage/share/AppLauncherEnvTest.java line 93:
>>
>>> 91: } else {
>>> 92: TKit.assertEquals(expectedEnvVarValue, actualEnvVarValue,
>>> msg);
>>> 93: }
>>
>> I'd keep the check as a single statement:
>>
>> TKit.assertTextStream(expectedEnvVarValue)
>> .predicate(TKit.isLinux() ? String::endsWith : String::equals)
>> .label(String.format("value of %s env variable", envVarName))
>> .apply(Stream.of(actualEnvVarValue));
>>
>>
>> It also will produce a nicer log record than `TKit.assertTrue(false, msg);`
>
> Hi Alexey, I adjusted the check following your advice .
Thank you!
-------------
PR: https://git.openjdk.org/jdk/pull/13041
