On Mon, 13 Mar 2023 14:42:26 GMT, Alan Bateman <al...@openjdk.org> wrote:

> jlink doesn't run with a security manager so no need for the 
> AccessController.doPriv.

Thank you for that detail - I've now removed the SecurityManager checks from 
this newly introduced code.

> Assuming the name of the jmod file is probably okay.

Were you thinking of exploded builds? I'm not too familiar with exploded 
builds, but after you commented here about the `.jmod` extension, I checked the 
existing code in `JLinkTask` and I can see that we seem to allow the module to 
be packaged as a `.jar` too, like here 
https://github.com/openjdk/jdk/blob/master/src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java#L834.
 Do you think this cross platform image creation would be relevant/used with 
exploded builds and if so, should I update the PR to address it?

-------------

PR: https://git.openjdk.org/jdk/pull/11943

Reply via email to