> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being > launched, the code would assume the byte order in the image to be the native > order of the host where the image is being launched. That would result in > failure to launch java, as noted in the linked issue. > > The commit in this PR, changes relevant places to not assume native order and > instead determine the byte order by reading the magic bytes in the image > file's header content. > > A new jtreg test has been added which reproduces the issue and verifies the > fix.
Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision: - only include known supported arch - Alan's suggestion - look into the ModuleTarget attribute in module-info.class only if this is a cross-platform image generation ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11943/files - new: https://git.openjdk.org/jdk/pull/11943/files/e68c2105..bad17122 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11943&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11943&range=03-04 Stats: 79 lines in 2 files changed: 52 ins; 4 del; 23 mod Patch: https://git.openjdk.org/jdk/pull/11943.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11943/head:pull/11943 PR: https://git.openjdk.org/jdk/pull/11943
