On Fri, 10 Mar 2023 17:27:11 GMT, Justin Lu <j...@openjdk.org> wrote:

> This PR modifies `java.util.LocaleISOData.isoLanguageTable` to include (name 
> only) changes from up-to-date [ISO 639 
> data](http://www.loc.gov/standards/iso639-2/php/code_list.php.).
> 
> In addition, this PR updates the ISO 639 data (generated in 1999) in 
> `Bug4175998Test.java`. This includes modifying the `generate_Tables() 
> `function, since the source data is now stored in a different format. The 
> outdated raw data stored in the bottom of the file was removed.

Looks good.

test/jdk/java/util/Locale/Bug4175998Test.java line 284:

> 282:                 System.out.print("\""+iso639_2B+"\",");
> 283:                 System.out.print("\""+iso639_2T+"\"");
> 284:                 System.out.println("},");

Could be simplified like

System.out.printf("""
    {"%s","%s","%s"},
""", iso639_1, iso639_2B, iso639_2T);

-------------

Marked as reviewed by naoto (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12980

Reply via email to