On Mon, 6 Mar 2023 17:11:42 GMT, Adam Sotona <asot...@openjdk.org> wrote:
>> This is root pull request with Classfile API implementation, tests and >> benchmarks initial drop into JDK. >> >> Following pull requests consolidating JDK class files parsing, generating, >> and transforming >> ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will chain to >> this one. >> >> Classfile API development is tracked at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-branch >> >> Development branch of consolidated JDK class files parsing, generating, and >> transforming is at: >> https://github.com/openjdk/jdk-sandbox/tree/classfile-api-dev-branch >> >> Classfile API [JEP](https://bugs.openjdk.org/browse/JDK-8280389) and [online >> API >> documentation](https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/internal/classfile/package-summary.html) >> is also available. >> >> Please take you time to review this non-trivial JDK addition. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request incrementally with one additional > commit since the last revision: > > snippets and tests synced with jdk.jfr class instrumentation source code src/java.base/share/classes/jdk/internal/classfile/components/CodeRelabeler.java line 44: > 42: > 43: /** > 44: * CodeRelabeler is a {@link jdk.internal.classfile.CodeTransform} > replacing all occurrences Nit - perhaps just use `A code relabeler is a ...` (instead of using the class name, which then would require another `{@code ... }`. src/java.base/share/classes/jdk/internal/classfile/components/package-info.java line 114: > 112: * {@snippet lang="java" class="PackageSnippets" > region="classInstrumentation"} > 113: */ > 114: package jdk.internal.classfile.components; watch out for newline ------------- PR: https://git.openjdk.org/jdk/pull/10982
