On Sun, 5 Mar 2023 06:19:06 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> While the review of https://github.com/openjdk/jdk/pull/12800 finishes up, I >> thought I'd get out for the review the next phase of the FDLIBM port: >> removing the FDLIBM C sources from the repo. >> >> A repo with the changes for JDK-8302027 and this PR successful build on the >> default set of platform and successfully run tier 1 tests, which includes >> tests of the math library. >> >> There are a few remaining references to the case-independent string "fdlibm" >> in the make directory and HotSpot sources. HotSpot contains a partial fork >> for FDLIBM (a tine of FDLIBM?) to use for intrinsics. The remaining make >> machinery contains logic to determine what set of gcc options can be used >> for the compile. >> >> The intention of this change is to remove use of FDLIBM for the core >> libraries. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains 20 commits: > > - Merge branch 'master' of https://git.openjdk.org/jdk into JDK-8302801-expr > - Respond to review feedback. > - Respond to review feedback and add description of transliteration process. > - JDK-8302801: Remove fdlibm C sources > - Update src/java.base/share/classes/java/lang/FdLibm.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - Update src/java.base/share/classes/java/lang/FdLibm.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - Update src/java.base/share/classes/java/lang/FdLibm.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - Update src/java.base/share/classes/java/lang/FdLibm.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - Update src/java.base/share/classes/java/lang/FdLibm.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - Update src/java.base/share/classes/java/lang/FdLibm.java > > Co-authored-by: Andrey Turbanov <turban...@gmail.com> > - ... and 10 more: https://git.openjdk.org/jdk/compare/1bb39a95...437a8fce I don't have any other comments on this, looks good. ------------- Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.org/jdk/pull/12821
