On Fri, 3 Mar 2023 21:10:57 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> This change is to fix a regression caused by the fix to >> [JDK-8234347](https://bugs.openjdk.org/browse/JDK-8234347). The previous fix >> was simply disabling offset-based parsing if the parser was text-based. >> Instead, check if it is an offset or not by explicitly comparing the >> character with '+'/'-' and continue offset parsing if it is. > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > now() -> of() to avoid DST test/jdk/java/time/test/java/time/format/TestUTCParse.java line 63: > 61: public void testUTCShortNameRoundTrip() { > 62: var fmt = DateTimeFormatter.ofPattern("z", Locale.FRANCE); > 63: var now = ZonedDateTime.of(2023, 3, 3, 0, 0, 0, 0, > ZoneId.of("America/Los_Angeles")); Nit, this is no longer `now`. Should it renamed to avoid confusion? ------------- PR: https://git.openjdk.org/jdk/pull/12868
