On Fri, 17 Feb 2023 10:20:46 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
> This is a proposal to upgrade the JLine inside JDK to 3.22.0. It was done by:
> -for shared/classes, taking a diff between JLine 3.20.0 and the existing JDK
> version, copying the JLine 3.22.0 into the JDK, repackaing, re-appling the
> patch (including trailing space removal, UTF-8 characters replacement,
> addition of inputStreamWrapper), and adjusting TerminalProvider
> -for Windows, mostly copying the JLine 3.22.0 code into the JDK, and
> adjusting based on old changes
some nit comments for your consideration, approved
src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/LineReaderImpl.java
line 5086:
> 5084: if (groupName) {
> 5085: Comparator<String> groupComparator = getGroupComparator();
> 5086: Map<String, Map<Object, Candidate>> sorted;
Candidate and String both implement Comparable, probably that could be used to
provide a more specific common supertype
src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlocking.java
line 147:
> 145: this.input = input;
> 146: this.decoder = decoder;
> 147: this.bytes = ByteBuffer.allocate(2048);
wow, big difference in allocation size
-------------
Marked as reviewed by vromero (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12614
