On Thu, 23 Feb 2023 17:31:02 GMT, Ian Graves <[email protected]> wrote:
>> This is an approach to adding a flag to jlink that will allow --compress to
>> take the same types of arguments as jmod, thus bringing the two into
>> alignment. This likely requires a CSR and a discussion on whether we should
>> deprecate or simply remove the original numeric compression arguments.
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Tweaking properties
Looks good in general. Minor comments.
src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultCompressPlugin.java
line 96:
> 94: switch (level) {
> 95: case LEVEL_0:
> 96: System.err.println(getMessage("warn.prefix") + " " +
Suggestion:
System.err.println(getMessage("compress.warn.argumentdeprecated", level));
It can be simpler to out the warning prefix in the message. Same for line 102
and 107.
src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins.properties line
74:
> 72:
> 73: compress.warn.argumentdeprecated=\
> 74: The {0} argument for --compress has been deprecated and will be removed
> from a future release
Suggestion:
Warning: The "{0}" argument for --compress is deprecated and may be removed
from a future release.
-------------
Marked as reviewed by mchung (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11617
