On Fri, 10 Feb 2023 20:35:58 GMT, Naoto Sato <na...@openjdk.org> wrote:
> Upgrading the GB18030 charset in the JDK to the latest 2022 standard. Since > this is not a compatible upgrade to the existing mapping, a new system > property `jdk.charset.GB18030` is introduced. If it is set to "2000", the > mapping falls back to the existing mapping based on the 2000 standard, > otherwise, it defaults to 2022 mapping. Refer to the corresponding CSR for > more detail. Overall I think it looks very good, just StandardCharsets.isGB18030_2000 needs attention. Having GB18030 be in java.base in all builds, rather than everywhere except macOS, is okay and makes things a lot simpler. ------------- PR: https://git.openjdk.org/jdk/pull/12518
