On Mon, 13 Feb 2023 11:02:14 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> test/jdk/java/lang/runtime/RuntimeExitLogTest.java line 89:
>> 
>>> 87:         }
>>> 88:         cmd.add(this.getClass().getName());
>>> 89:         cmd.add(Integer.toString(status));
>> 
>> Another possibility for testing this is to launch with ` --limit-modules 
>> java.base -Djdk.system.logger.level=DEBUG` to use the simple console 
>> implementation that is in java.base and avoid needing properties files for 
>> j.u.logging. Just mentioning is an option to make it simple.
>
> Good point - though maybe both configurations should be tested. The 
> j.u.l.LogManager registers some shutdown hook so I believe it's important to 
> test with j.u.l present too.

Added a test of the console config with --limit-modules as suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/12517

Reply via email to