On Wed, 8 Feb 2023 03:42:16 GMT, Mandy Chung <mch...@openjdk.org> wrote:

>> A trivial fix.   Convert the use of anonymous inner classes in a few 
>> Permission classes to lambdas to work around JDK-8076596, which has been 
>> resolved.
>
> Mandy Chung has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   update copyright end year

LGTM. I can't help noticing that the code for SocketPermission, 
PropertyPermission, and ServicePermission is almost identical. But there's not 
much we could do factorize that easily since the lambda requires access to 
private static method accessors: trying to factorize would probably add to the 
complexity instead of reducing it and impair readability.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12463

Reply via email to