On Tue, 7 Feb 2023 16:07:00 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cleanup
>
> src/java.base/share/classes/jdk/internal/classfile/attribute/NestMembersAttribute.java
> line 72:
>
>> 70: * @param nestMembers the member classes of the nest
>> 71: */
>> 72: static NestMembersAttribute ofSymbols(List<ClassDesc> nestMembers) {
>
> I see that in some classes we use the `Symbols` prefix, in others we just use
> `of` - we should try to make the more consistent (in the future).
`ofSymbols` is an alternative to `of` when conflicting method parameters.
In such case `of` refers to CP entries and `ofSymbols` refer to independent
symbols describing the objects, like for example `ClassDesc`, `MethodTypeDesc`,
`PackageDesc`
-------------
PR: https://git.openjdk.org/jdk/pull/10982
