On Tue, 7 Feb 2023 16:09:56 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org>
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>> - TypeAnnotation.TypePathComponent cleanup
>
> src/java.base/share/classes/jdk/internal/classfile/attribute/StackMapTableAttribute.java
> line 68:
>
>> 66: * A simple stack value.
>> 67: */
>> 68: public enum SimpleVerificationTypeInfo implements
>> VerificationTypeInfo {
>
> I note that in this class we have made the decision to model all the innards
> (XYZInfo) as nested classes - while in all the other cases XYZInfo are
> toplevel types. Moving forward, we should pick something consistent.
Every case has been considered individually, evaluated on use cases and pros
and cons have been weighted. Unified approach across the whole API would be
nice, however not so simple and not the highest priority.
-------------
PR: https://git.openjdk.org/jdk/pull/10982
