On Tue, 7 Feb 2023 09:38:13 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Please review this patch that reduces the socket timeout used in >> HandshakeTimeout test to its minimum value of 1 millisecond. >> >> This change makes the test complete 10 seconds faster; before this change it >> took 5 seconds for the handshake to timeout, and the test attempts 2 >> handshakes. >> >> The change also makes the test more likely to pass when it has to compete >> with other tests for CPU time. > > Daniel Jeliński has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains three additional > commits since the last revision: > > - Restructure test > - Merge remote-tracking branch 'origin' into rmi-test-timeout > - Reduce socket timeout Marked as reviewed by msheppar (Reviewer). the restructuring is good idea. I never think of running clint and server in same thread, but it will eliminate any possibility of race between main thread and Connector thread. so job done (LGTM) ------------- PR: https://git.openjdk.org/jdk/pull/12292
