On Fri, 3 Feb 2023 17:20:19 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Classfile API moved under jdk.internal.classfile package > > src/java.base/share/classes/jdk/internal/classfile/TypeAnnotation.java line > 617: > >> 615: } >> 616: >> 617: public static final TypePathComponent ARRAY = new >> UnboundAttribute.TypePathComponentImpl(Kind.ARRAY, 0); > > `public static final` is redundant here (it's an interface) - please check > these (I've seen others). E.g. all `public` modifier for types nested in > interfaces are redundant as well. yes, will fix and search for other such cases, thanks. ------------- PR: https://git.openjdk.org/jdk/pull/10982
