On Mon, 6 Feb 2023 01:50:55 GMT, Joe Darcy <da...@openjdk.org> wrote:
> To help add assurances that the main-line port of FDLIBM to Java is working > correctly, added some long-running manual tests to probe that the > transliteration port and the corresponding StrictMath method are in agreement > on a large number of argument, say, all float values. > > To test the transliteration port, this test can be run against a build where > the JDK has *not* had the FDLIBM code used for StrictMath ported to Java. Manual tests are the tests of last resort :-) This test may be useful for the current transliteration work but it's not clear how this manual test would be run by someone tasked with running the manual tests. Right now, it looks like it's more of a long running stress test but I think the expectation is that someone running this test needs to do a special build or somehow compare results with an older JDK release. Have you explored alternatives to adding a manual test? Long running HotSpot stress tests run in higher tiers. For comparison, I'm wondering if samples could be captured in a golden file for the test to use. If we are adding a manual test here then I think it will need good instructions. @bwhuang-us has done work in recent times on making sure that the manual tests are in test groups with instructions. ------------- PR: https://git.openjdk.org/jdk/pull/12430
