On Thu, 2 Feb 2023 00:34:32 GMT, Claes Redestad <redes...@openjdk.org> wrote:
>> These tables are used for both URL and non-URL based on the parameter, and >> they are only two of the three lut tables used (the other is in >> `base64_AVX2_decode_tables_addr` ). Both names are essentially incorrect. >> Does the name really matter that much? It's the same as >> `base64_AVX2_decode_tables_addr` with the addition of URL tables. > > Names are important, but always hard to get right. At the very least they > need to be correct. Maybe call it something like > `..parameterized_decode_tables..` and the other `..shared_decode_tables..`? I prefer leaving them the way they are. I don't think the names, along with the associated comments within the tables, causes any undue confusion as to their function. However I will implement the name change if that's all it takes to procure a review approval. Please provide the specific names you'd like me to use and I'll change them. Or just approve as-is :-). ------------- PR: https://git.openjdk.org/jdk/pull/12126
