On Wed, 1 Feb 2023 20:16:56 GMT, cheenar <d...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Simplify benchmark
>> - Add benchmark
>
> test/jdk/java/time/tck/java/time/zone/TCKFixedZoneRules.java line 141:
>
>> 139: @Test(dataProvider="rules")
>> 140: public void test_isValidOffset_LDT_ZO(ZoneRules test, ZoneOffset
>> expectedOffset) {
>> 141: if (expectedOffset == ZoneOffset.UTC)
>
> Extremely minor but why not wrap if with `{}` for improved readability here
> with the comment
Same
[here](https://github.com/openjdk/jdk/pull/12346/commits/ec49ca3bc03d2e97fa0429c84290923066667871?diff=unified&w=0#diff-9e5aa282dc2d02c31e1d7c5ec8196a1d3d23c06e471d5114d0bd0c78ee4fe5f6R433)
although it feels much more dangerous than the test!
-------------
PR: https://git.openjdk.org/jdk/pull/12346
