On Wed, 25 Jan 2023 00:50:04 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor punctuation > > src/java.base/share/classes/java/util/TimeZone.java line 297: > >> 295: * the time zone object. >> 296: * @param ID the new time zone ID. >> 297: * @implSpec The default implementation throws a > > Usually @implSpec follows the method description, apart from other tags. See > https://openjdk.org/jeps/8068562 Thanks, will reference this for future use of javadoc tags > src/java.base/share/classes/java/util/TimeZone.java line 404: > >> 402: * @implSpec The default implementation throws a >> 403: * {@code NullPointerException} if {@code ID} is {@code null}. >> 404: * Additionally, an {@code IllegalArgumentException} will be thrown >> if > > I'd concatenate these with "or". Also, I think `IllegalArgumentException` has > higher priority in the case of both being null/invalid. Swapped the priority, and improved the wording ------------- PR: https://git.openjdk.org/jdk/pull/11888
