On Tue, 17 Jan 2023 11:34:52 GMT, Alan Bateman <al...@openjdk.org> wrote:
> The ModuleReader implementation for exploded modules maps resource names to > file paths. A small oversight is that it doesn't handle InvalidPathException > which is thrown when the resource name maps to something that can't be parsed > as a file path. This has a knock on impact to Class/ClassLoader > getResourceXXX and other usages of ModuleReader. > > The existing ModuleReaderTest is updated to include additional resource names > to test. I've also moved `@Test` annotation to the test methods so that it's > a bit clearer which are the test methods in this source file. Looks good to me. Should we also add a `C:/java` (one with a forward slash) to the new junk resource names added in this test, to exercise the path where a forward slash is present in a resource name which also has the Windows disallowed `:` character in it? ------------- Marked as reviewed by jpai (Reviewer). PR: https://git.openjdk.org/jdk/pull/12035
