On Tue, 17 Jan 2023 10:06:57 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> - Strengthen a computation that could overflow. >> - Specify that use of CANON_EQ could exhaust memory in the compilation phase. > > src/java.base/share/classes/java/util/regex/Pattern.java line 1099: > >> 1097: * flags. >> 1098: * >> 1099: * <p>Setting {@link #CANON_EQ} among the flags may impose a >> moderate risk > > This may be a candidate for `@apiNote`, same thing for the note added to > CANON_EQ. The choice of a `<p>` paragraph rather than `@apiNote` is for consistency with similar commentary paragraphs in the specs of `CASE_INSENSITIVE`, `UNICODE_CASE`, and `UNICODE_CHARACTER_CLASS`. I have no problems in using `@apiNote` instead, but then it would be better to apply the same for the other mentioned flags as well. ------------- PR: https://git.openjdk.org/jdk/pull/12027