On Wed, 11 Jan 2023 11:53:58 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> This change transforms a O(n^2) path to O(n) when prepending zero padding to 
>> decimal outputs, where n is the length of the padding.
>
> I assume this issue has been there for a long time, just not noticed because 
> it would be unusual to specify a width of this magnitude. The switch to using 
> repeat + one insert looks good. Are you okay for tests in this area?

> @AlanBateman This is not a functional bug, only an enhancement to overcome 
> the long times for large, unrealistic widths.
> Consequently, I have no specific tests that measure the timing against some 
> hard-coded limits, if I understand you correctly.

My question wasn't phrased very well, I was really just asking if we have good 
test coverage for width in the format specifier  so that it would catch any 
regressions from changes to this code.

-------------

PR: https://git.openjdk.org/jdk/pull/11939

Reply via email to