On Tue, 6 Dec 2022 12:07:35 GMT, Jaikiran Pai <j...@openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add test
>
> test/jdk/sun/net/www/http/KeepAliveStream/KeepAliveStreamFinalizer.java line 
> 28:
> 
>> 26:  * @bug 8240275
>> 27:  * @library /test/lib
>> 28:  * @run main/othervm KeepAliveStreamFinalizer
> 
> Hello Daniel, it doesn't look like we are doing anything JVM specific in this 
>  test. Is the `othervm` intentional here?

The test calls `HttpsURLConnection.setDefaultSSLSocketFactor` which requires 
using `/othervm`

-------------

PR: https://git.openjdk.org/jdk/pull/11474

Reply via email to