On Mon, 5 Dec 2022 10:16:22 GMT, Viktor Klang <d...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Expand test >> - Adjust wording to make it clear that the number of tasks is non-negative >> - Merge >> - Improve javadoc >> - Merge >> - Initial commit > > src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2920: > >> 2918: * @since 20 >> 2919: */ >> 2920: public <T> ForkJoinTask<T> externalSubmit(ForkJoinTask<T> task) { > > @AlanBateman Does it make sense to check the nullness of the `task` before > going into the storeStoreFence etc? It's only to be the same as poolSubmit. ------------- PR: https://git.openjdk.org/jdk/pull/11319