On Wed, 30 Nov 2022 18:17:47 GMT, Sergey Tsypanov <stsypa...@openjdk.org> wrote:

>> `String.offsetByCodePoints()` delegates to `Character.offsetByCodePoints()` 
>> which in turn specifies the same exception thrown under the same conditions 
>> and the implementation does exactly the same checks. This means we can 
>> remove the check from `String.offsetByCodePoints()` and rely on the one of 
>> `Character.offsetByCodePoints()`.
>
> Sergey Tsypanov has updated the pull request with a new target base due to a 
> merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains three additional 
> commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8297561
>  - 8297561: Add benchmark
>  - 8297561: Redundant index check in String.offsetByCodePoints()

LGTM

-------------

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11350

Reply via email to