On Mon, 21 Nov 2022 07:42:35 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> N.B.: Regarding usage numbers, I will do a quick poll on Twitter. > >> Indeed my intention solely is to get rid of `Vector`, so I am fine with >> keeping a low profile and being full backwards compatible. I assume SIS is >> seldomly used, so opening a can of warms is not worth it (I think). > > If you have the cycles then collecting data on usages and finding examples > where the constructor is called with a second parameter of null would be > useful. It's a lot of work to do that of course. The changes in update > 2e957354 look okay, I can't immediately see any behavior change with that > version. I think the public visibility of my Twitter account is not wide enough to get *really robust* answers, unfortunately. So far, 92% answered that they not even used SIS in their whole life. So the users of two-args constructor must be really neglectable. Nevertheless, they are definitively not zero, so all we could do is marking it deprecated some day. Anyways, thanks for the review. At least we get rid of `Vector` here. Would be happy if you mark the PR as reviewed. :-) ------------- PR: https://git.openjdk.org/jdk/pull/11249
