On Fri, 28 Oct 2022 19:33:38 GMT, Rémi Forax <fo...@openjdk.org> wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update TemplateRuntime::combine
>
> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 289:
>
>> 287: try {
>> 288: MethodHandles.Lookup lookup = MethodHandles.lookup();
>> 289: MethodHandle getter =
>> lookup.findStatic(TemplateRuntime.class, "getValue",
>
> This should be a constant (using the class holder idiom or not)
Changing
> src/java.base/share/classes/java/lang/template/TemplateRuntime.java line 302:
>
>> 300:
>> 301: /**
>> 302: * Private ethod used by {@link
>> TemplateRuntime#valueGetters(StringTemplate)}
>
> Private "method"
Changing
-------------
PR: https://git.openjdk.org/jdk/pull/10889
