On Wed, 19 Oct 2022 16:45:12 GMT, Lance Andersen <lan...@openjdk.org> wrote:
> Hi all, > > Please review this PR which will update the Zlib Data Compression Library > from 1.2.11 to 1.2.13. > > - I have run all of the Mach5 tiers which did not show any issues related to > the upgrade. > - The JCK zip/jar tests also continue to pass. > - Jai ran his macOS aarch64 test(for > [JDK-8282954](https://bugs.openjdk.org/browse/JDK-8282954)) with the zlib > 1.2.13 port and has not seen the failure as seen with the MacOS aarch64 > native zlib port > > > Best, > Lance Marked as reviewed by jpai (Reviewer). I checked out Mark Adler's upstream 1.2.13 tag https://github.com/madler/zlib/tree/v1.2.13 locally and then ran `diff src/java.base/share/native/libzip/zlib <root-of-1.2.13-of-madler-repo>`. The diff shows that for the (common) files that we have in this PR, there's no difference other than additional copyright headers. Additionally against Mark's upstream git repo, I ran: git diff --name-only --diff-filter=A v1.2.11 v1.2.13 to find any newly added files (that might be relevant to us) between these 2 versions. The output is: .github/workflows/cmake.yml .github/workflows/configure.yml .github/workflows/fuzz.yml LICENSE doc/crc-doc.1.0.pdf examples/gznorm.c examples/zran.h None of which is relevant to JDK. I also ran: git diff --name-only --diff-filter=D v1.2.11 v1.2.13 to find any deleted files between these 2 versions and the output is: contrib/amd64/amd64-match.S contrib/asm686/README.686 contrib/asm686/match.S contrib/inflate86/inffas86.c contrib/inflate86/inffast.S contrib/masmx64/bld_ml64.bat contrib/masmx64/gvmat64.asm contrib/masmx64/inffas8664.c contrib/masmx64/inffasx64.asm contrib/masmx64/readme.txt contrib/masmx86/bld_ml32.bat contrib/masmx86/inffas32.asm contrib/masmx86/match686.asm contrib/masmx86/readme.txt none of which appear relevant to us. Finally, I ran: git diff --name-only --diff-filter=R v1.2.11 v1.2.13 to find any renamed files. This returns no output (since nothing was renamed). So overall, the change in this PR looks good to me and appears to be same as what's there in 1.2.13 of upstream. ------------- PR: https://git.openjdk.org/jdk/pull/10773
