On Mon, 3 Oct 2022 08:23:36 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> 
wrote:

> Disables a specific assertion that causes intermittent failures.

Approved whether or not any comment is added.

test/jdk/java/util/DoubleStreamSums/CompensatedSums.java line 94:

> 92: 
> 93:         Assert.assertTrue(jdkParallelStreamError <= 
> goodParallelStreamError);
> 94: //        Assert.assertTrue(badParallelStreamError >= 
> jdkParallelStreamError);

Maybe a comment here, something like in the issue description?

// Due to floating-point addition being inherently non-associative, and due to 
the unpredictable scheduling of the threads used in parallel streams, this 
assertion can fail intermittently hence is suppressed for now.

-------------

Marked as reviewed by bpb (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10529

Reply via email to