On Tue, 11 Oct 2022 01:48:41 GMT, Stuart Marks <sma...@openjdk.org> wrote:

>> Tagir F. Valeev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Remove Random -> ThreadLocalRandom change
>
> test/jdk/java/util/Collections/Shuffle.java line 92:
> 
>> 90:             throw new RuntimeException(list.getClass() + ": " + list + " 
>> != " + copy);
>> 91:         }
>> 92:     }
> 
> Is there a way to factor out the `shuffle` calls and thereby collapse these 
> two methods into one? Is it worth it? I'm thinking you could pass in a 
> `Consumer<List<Integer>>`.

Good idea, thanks! Will do.

-------------

PR: https://git.openjdk.org/jdk/pull/10520

Reply via email to