On Wed, 31 Aug 2022 05:47:21 GMT, liach <d...@openjdk.org> wrote: >> liach has updated the pull request with a new target base due to a merge or >> a rebase. The incremental webrev excludes the unrelated changes brought in >> by the merge/rebase. The pull request contains six additional commits since >> the last revision: >> >> - Move tests >> - Merge branch 'master' into fix/identityhashmap-default >> - Fix assertions >> - Revamp test and changes. Let ci run the tests >> - Fix indent >> - 8178355: IdentityHashMap uses identity-based comparison for values >> everywhere except remove(K,V) and replace(K,V,V) > > Let's wait
@liach Thanks for merging in a recent master. I started looking at this now. The tests and implementation look good. I've run this through our internal build&test system and the results look good too. Per @dfuch comment of June 1 I also looked at various method specs to see whether they would need to be updated to have reference-equality semantics. The specs are all in mostly pretty good shape, but I did add a few clauses here and there and I also added some cross-references, so I think the spec is overall much tighter now. I've pushed a branch with my proposed spec changes. Please merge from https://github.com/stuart-marks/jdk/tree/JDK-8178355-IdentityHashMap which should be based on the current head of this PR branch. The next step would be the CSR. I'd suggest updating in the (slightly) revised specs of remove() and replace() in the Specification section, but otherwise leaving them pretty much as they are, and not bothering with diffs for all the other tweaks I did. I'll generate a specdiff (internal tool, sorry, basically a structured HTML diff) and then post that to the CSR to provide a complete record of the changes. ------------- PR: https://git.openjdk.org/jdk/pull/8259
