On Fri, 30 Sep 2022 10:51:53 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> We noticed that with certain jar file input, jdeps runs into the following
>> exception, this happens with jdk11, 17 and 20.
>>
>> jdeps.exe --multi-release 11 --module-path . --inverse --package
>> com.sap.nw.performance.supa.client test.jar
>>
>> Inverse transitive dependences matching packages
>> [com.sap.nw.performance.supa.client]
>> Exception in thread "main" java.util.NoSuchElementException: No value present
>> at java.base/java.util.Optional.get(Optional.java:148)
>> at
>> jdk.jdeps/com.sun.tools.jdeps.InverseDepsAnalyzer.lambda$inverseDependences$2(InverseDepsAnalyzer.java:150)
>> at
>> java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
>> at
>> java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
>> at
>> java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195)
>> at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
>> at
>> java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
>> at
>> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>> at
>> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>>
>> So an additional check might be a good idea.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Adjust test
test/langtools/tools/jdeps/optionalDependency/OptionalDependencyTest.java line
73:
> 71: */
> 72: @Test
> 73: public void optionalDependenceResolved() {
Since you removed `--add-modules m3` is removed, this test case is
`OptionalDependenceNotResolved`. Although the bug only happens if m3 is not
resolved in the configuration, a test case to resolve m3 (with `--add-modules
m3`) is for completeness and also helps future debugging in case any of these
cases was broken.
-------------
PR: https://git.openjdk.org/jdk/pull/10300
