On Mon, 26 Sep 2022 12:53:49 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use wildcard function > > make/modules/java.base/gendata/GendataTZDB.gmk line 33: > >> 31: TZDATA_DIR := $(MODULE_SRC)/share/data/tzdata >> 32: TZDATA_TZFILE := africa antarctica asia australasia europe northamerica >> southamerica backward etcetera gmt jdk11_backward >> 33: TZDATA_TZFILES := $(TZDATA_DIR)/* > > Have you verified that this works? I would expect a wildcard call to be > needed. > Suggestion: > > TZDATA_TZFILES := $(wildcard $(TZDATA_DIR)/*) I confirmed the fix worked, on my local mac and mach5. However, your suggestion does seem the right way. Modified the fix as suggested. ------------- PR: https://git.openjdk.org/jdk/pull/10415