On Fri, 23 Sep 2022 06:56:20 GMT, Hao Sun <hao...@openjdk.org> wrote:
>> make/modules/java.base/lib/CoreLibraries.gmk line 52: >> >>> 50: CFLAGS_aix := -qfloat=nomaf, \ >>> 51: DISABLED_WARNINGS_gcc := sign-compare misleading-indentation \ >>> 52: array-bounds maybe-uninitialized, \ >> >> Something like this would be better: >> >> #pragma GCC diagnostic push >> #pragma GCC diagnostic ignored "-Wmaybe-uninitialized" >> write(foo, bar, baz); >> #pragma GCC diagnostic pop > > Thanks for your review. > > Your mentioned solution should work and we can also enable the pragma only > for aarch64 + gcc>=12 condition. > I considered such a solution when preparing this patch. > > But I personally prefer to suppress the waring in the makefile, mainly > because fdlibm is 3rd party library and we'd better not changing the source > code. I think it is a long-standing policy. Yes, we should not modify 3rd party code. What you would need is [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281). If you can hold back this patch for a little while, you'll be able to utilize it instead. ------------- PR: https://git.openjdk.org/jdk/pull/10386
