Hi Michael, On Sep 16, 2022, at 6:19 PM, Michael Hall <mik3h...@gmail.com<mailto:mik3h...@gmail.com>> wrote:
On Sep 16, 2022, at 6:02 PM, Alexander Matveev <almat...@openjdk.org<mailto:almat...@openjdk.org>> wrote: Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850) never set correct value in .jpackage.xml to mark image as signed. [JDK-8289030](https://bugs.openjdk.org/browse/JDK-8289030) reads this value to check if we can add per-user and system wide configuration to packaged app. Fixed by setting correct value in .jpackage.xml when we signing predefine application image. Alexander, I think I figured out how to include PR’s in my build and this appears good. codesign -v --verbose=4 "/Volumes/BlackJack Blastoff_Unsigned/BlackJack Blastoff_Unsigned.app" /Volumes/BlackJack Blastoff_Unsigned/BlackJack Blastoff_Unsigned.app: valid on disk /Volumes/BlackJack Blastoff_Unsigned/BlackJack Blastoff_Unsigned.app: satisfies its Designated Requirement This was new… Warning: Support for per-user configuration of the installed application will not be supported due to missing "BlackJack Blastoff_Unsigned.app/Contents/app/.package" in predefined signed application image. I’m not quite sure what it’s saying but it doesn’t seem to impact what I’m doing. This warning means that support for per-user configuration of the installed application will be disabled. We added support for per-user configuration with https://bugs.openjdk.org/browse/JDK-8250950 (Allow per-user and system wide configuration of a jpackaged app). Thanks, Alexander Thanks, Mike FWIW, I ran into [macos] cmstypes.c fails compilation with Xcode13.3 https://bugs.openjdk.org/browse/JDK-8283221 Adding this which I noticed in the source… cmsUNUSED_PARAMETER(SizeOfTag); // mjh To the two erroring methods… ~/Documents/GitHub/jdk/build/macosx-x86_64-server-release/build.log:179: /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:3441:132: error: parameter 'SizeOfTag' set but not used [-Werror,-Wunused-but-set-parameter] ~/Documents/GitHub/jdk/build/macosx-x86_64-server-release/build.log:182: /Users/mjh/Documents/GitHub/jdk/src/java.desktop/share/native/liblcms/cmstypes.c:5137:125: error: parameter 'SizeOfTag' set but not used [-Werror,-Wunused-but-set-parameter] Seemed a fix. I could build.
