On Tue, 13 Sep 2022 05:23:20 GMT, Joe Wang <jo...@openjdk.org> wrote:
>> Rahul Prabhu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8289508: fixed whitespace > > It would be nice to cover some of the assertions made in the spec, e.g.: > 2.2 Axes > ... if the context node is an attribute node or namespace node, the > preceding-sibling axis is empty > > 3.3 Node-sets > ... > NOTE: The meaning of a Predicate depends crucially on which axis > applies. > For example, preceding::foo[1] returns the first foo element in > reverse document order, because the axis that applies to the [1] predicate is > the preceding axis; by contrast, (preceding::foo)[1] returns the first foo > element in document order, because the axis that applies to the [1] predicate > is the child axis. > > 5.7 Text Nodes > ... a text node never has an immediately following or preceding sibling > that is a text node @JoeWang-Java Added the tests you recommended, thanks for the suggestion. ------------- PR: https://git.openjdk.org/jdk/pull/10211
