On Wed, 14 Sep 2022 11:57:17 GMT, Alan Bateman <al...@openjdk.org> wrote:

> One other comment on the snippet is that the type of "jar" may not be obvious 
> to readers. I think you'll need Path jar = ... in which case changing it 
> Files.newInputStream(jar) might be simpler.

Updated per your suggestion

> I wonder if this paragraph should be an apiNote. It's not wrong as is but it 
> feels like a note to remind developers that this is an "input stream" for 
> iterating through the ZIP entries. The external files attributes are in the 
> CEN at the end of the ZIP file so this is why they aren't available.

converted to an apiNote

-------------

PR: https://git.openjdk.org/jdk/pull/10102

Reply via email to