On Thu, 1 Sep 2022 13:53:05 GMT, Weijun Wang <wei...@openjdk.org> wrote:
> It's better. Do you need to explicitly say "For all other cases"? I thought it is worth being specific, but happy to leave it out if you and others prefer > > My original comment was more about explaining `getManifest()` and > `getNextEntry()` in the same if. It's still doable. I think the challenge is there is not an exact match to the behavior between `getManifest()` and `getNext[Jar]Entry()`. We also have the case if the manifest is the first entry and META-INF/ is the 2nd or later entry, then META-INF/ will be returned by `JarInputStream`. ` ZipInputStream` will return all entries which differs from `JarInputStream` so thought it made sense to be specific but perhaps I am overthinking it. ------------- PR: https://git.openjdk.org/jdk/pull/10045
