On Tue, 6 Sep 2022 17:20:22 GMT, Markus KARG <[email protected]> wrote:
>> Implementation of JDK-8279283
>
> Markus KARG has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert "HexPrinter::transferTo"
>
> This reverts commit 6f0e2a8f7be5706b39a8e9bc88a97f34d2819098.
test/jdk/java/io/BufferedInputStream/TransferTo.java line 105:
> 103: public void testStreamContents() throws Exception {
> 104: // factory for incoming data provider
> 105: InputStreamProvider inputStreamProvider = byteArrayInput();
Given that the implementation in this PR now calls the wrapped `InputStream`'s
`transferTo` method, should we also include a test where the wrapped
`InputStream` is a `FileInputStream` and the target `OutputStream` is a
`FileOutputStream`, so that it exercises the `FileChannel#transferTo` code path
and verifies the correct data is transferred?
-------------
PR: https://git.openjdk.org/jdk/pull/6935
