On Thu, 25 Aug 2022 09:24:20 GMT, Raffaello Giulietti <d...@openjdk.org> wrote:
>> Add support for named groups to java.util.regex.MatchResult > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > 8065554: MatchResult should provide values of named-capturing groups src/java.base/share/classes/java/util/regex/MatchResult.java line 348: > 346: * > 347: * @apiNote > 348: * This method must be overridden by an implementation. This is a bit odd. It sounds like existing MatchResult implementations (outside the JDK) are now invalid. I think it really means something like, "This method must be overridden by an implementation in order to provide valid information about whether this MatchResult contains a match." I'm not sure whether saying this is necessary; it could be omitted. Probably also needs an `@throws UnsupportedOperationException` in case the match information is unavailable. ------------- PR: https://git.openjdk.org/jdk/pull/10000
