On Tue, 16 Aug 2022 08:23:11 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
> We have a few reports that existing Weak* VarHandle tests are still flaky, > for example on large AArch64 machines or small RISC-V machines. > > The flakiness is intrinsic to the nature of Weak* operations under tests, > that can spuriously fail. The last attempt to fix these was > [JDK-8155739](https://bugs.openjdk.org/browse/JDK-8155739). We need to > strengthen these a bit more. > > The actual values depend on the successful testing on known-failing > platforms. I ballparked bumping the attempts 5x and introducing the delay > would help without exploding test time in worst cases. Results on hifive, running all tests in VarHandles dir: Test results: passed: 22; failed: 2; error: 14 many tests timed out: VarHandleTestAccessChar.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 127589ms). VarHandleTestAccessInt.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122091ms). VarHandleTestAccessLong.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122116ms). VarHandleTestByteArrayAsFloat.jtr:test result: Error. Program `bin/java' timed out (timeout set to 360000ms, elapsed time including timeout handling was 362103ms). VarHandleTestByteArrayAsInt.jtr:test result: Error. Program `bin/java' timed out (timeout set to 360000ms, elapsed time including timeout handling was 362061ms). VarHandleTestMethodHandleAccessBoolean.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122087ms). VarHandleTestMethodHandleAccessByte.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122059ms). VarHandleTestMethodHandleAccessChar.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122106ms). VarHandleTestMethodHandleAccessDouble.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122093ms). VarHandleTestMethodHandleAccessFloat.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122092ms). VarHandleTestMethodHandleAccessInt.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122081ms). VarHandleTestMethodHandleAccessLong.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122123ms). VarHandleTestMethodHandleAccessShort.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122096ms). VarHandleTestMethodHandleAccessString.jtr:test result: Error. Program `bin/java' timed out (timeout set to 120000ms, elapsed time including timeout handling was 122217ms).` ------- two failed as before: ` test VarHandleTestAccessShort.testAccess("VarHandle -> Array", VarHandle -> Array): failure java.lang.AssertionError: weakCompareAndSetRelease short expected [true] but found [false] at org.testng.Assert.fail(Assert.java:99) at org.testng.Assert.failNotEquals(Assert.java:1037) at org.testng.Assert.assertEqualsImpl(Assert.java:140) at org.testng.Assert.assertEquals(Assert.java:122) at org.testng.Assert.assertEquals(Assert.java:819) at VarHandleTestAccessShort.testArray(VarHandleTestAccessShort.java:1073) at VarHandleBaseTest$AccessTestCase.testAccess(VarHandleBaseTest.java:421) at VarHandleTestAccessShort.testAccess(VarHandleTestAccessShort.java:288) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:578) at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132) at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:599) at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174) at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46) at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822) at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147) at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146) at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128) at java.base/java.util.ArrayList.forEach(ArrayList.java:1511) at org.testng.TestRunner.privateRun(TestRunner.java:764) at org.testng.TestRunner.run(TestRunner.java:585) at org.testng.SuiteRunner.runTest(SuiteRunner.java:384) at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378) at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337) at org.testng.SuiteRunner.run(SuiteRunner.java:286) at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53) at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96) at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218) at org.testng.TestNG.runSuitesLocally(TestNG.java:1140) at org.testng.TestNG.runSuites(TestNG.java:1069) at org.testng.TestNG.run(TestNG.java:1037) at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:94) at com.sun.javatest.regtest.agent.TestNGRunner.main(TestNGRunner.java:54) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:578) at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) at java.base/java.lang.Thread.run(Thread.java:1589) ` similar with VarHandleTestAccessChar: java.lang.AssertionError: weakCompareAndSetRelease char expected [true] but found [false] ------------- PR: https://git.openjdk.org/jdk/pull/9889
