On Thu, 11 Aug 2022 20:02:06 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
> A trivial fix so that Continuation/Fuzz.java honors the timeoutFactor JTREG > setting > when waiting for a compilation to finish. > > This fix is being tested in my jdk-20+10 stress testing run. > > The usual Mach5 timeoutFactor is 4.0 with slower configurations using a > timeoutFactor > of 10.0. In my stress testing, I use release-bits: 4.0, fastdebug-bits: 6.0 > and slowdebug-bits: 12.0. > So you're trying to make sure we have a minimum COMPILATION_TIMEOUT value of > 5 seconds, but I'm not sure why you want that. With the current patch, `COMPILATION_TIMEOUT` may become less than 5_000, which may lead to more failures on various platforms. That's why I suggest let `COMPILATION_TIMEOUT >= 5_000`, which won't make things worse. Thanks. > Definitely not. Traditional default value for no specified timeoutFactor > value is 1.0. Okay, you're right. This is because the timeoutFactor may be used by other tests too. ------------- PR: https://git.openjdk.org/jdk/pull/9844