On Fri, 15 Jul 2022 18:41:09 GMT, Eric Caspole <ecasp...@openjdk.org> wrote:
> Adds Warmup, Measurement and Fork annotations to reduce the run time from 1
> day 16 hours to 8 hours for this set.
LGTM, some suggestions inline that you can choose to ignore
test/micro/org/openjdk/bench/java/util/ArraysFill.java line 48:
> 46: public class ArraysFill {
> 47:
> 48: @Param({"10", "16", "31", "59", "89", "126", "250", "266", "511",
> "1021", "2047", "2048", "4095", "8195"})
Can we prune a few of these?
test/micro/org/openjdk/bench/java/util/ArraysMismatchPartialInlining.java line
47:
> 45: public class ArraysMismatchPartialInlining {
> 46:
> 47: @Param({"3", "4", "5", "6", "7", "15", "31", "63", "95", "800"})
Can we prune a few of these? At least 4, 5, 6 seem like they'll not add much
signal.
test/micro/org/openjdk/bench/java/util/Base64VarLenDecode.java line 87:
> 85:
> 86: @Benchmark
> 87: @Warmup(iterations = 4, time = 2)
I prefer putting these at class level (even when there's only one `@Benchmark`)
-------------
Marked as reviewed by redestad (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9523
