> This is an early review of changes to better model JVM access flags, that is > "modifiers" like public, protected, etc. but explicitly at a VM level. > > Language level modifiers and JVM level access flags are closely related, but > distinct. There are concepts that overlap in the two domains (public, > private, etc.), others that only have a language-level modifier (sealed), and > still others that only have an access flag (synthetic). > > The existing java.lang.reflect.Modifier class is inadequate to model these > subtleties. For example, the bit positions used by access flags on different > kinds of elements overlap (such as "volatile" for fields and "bridge" for > methods. Just having a raw integer does not provide sufficient context to > decode the corresponding language-level string. Methods like > Modifier.methodModifiers() were introduced to cope with this situation. > > With additional modifiers and flags on the horizon with projects like > Valhalla, addressing the existent modeling deficiency now ahead of time is > reasonable before further strain is introduced. > > This PR in its current form is meant to give the overall shape of the API. It > is missing implementations to map from, say, method modifiers to access > flags, taking into account overlaps in bit positions. > > The CSR https://bugs.openjdk.java.net/browse/JDK-8281660 will be filled in > once the API is further along.
Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 53 additional commits since the last revision: - Expand testing of Class access flags. - Merge branch 'master' into JDK-8266670 - Merge branch 'master' into JDK-8266670 - Respond to review feedback from Mandy and Roger. - Remove implSpec tag from Executable.accessFlags since the class is sealed. - Improve support and tests for Class objects representing arrays and primitives. - Expand scope of tests. - Merge branch 'master' into JDK-8266670 - Add module-related tests. - Fix typo Exe-Boss spotted in review feedback. - ... and 43 more: https://git.openjdk.org/jdk/compare/124dc9b9...e2cccc16 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/7445/files - new: https://git.openjdk.org/jdk/pull/7445/files/63c48284..e2cccc16 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=7445&range=34 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=7445&range=33-34 Stats: 27409 lines in 673 files changed: 8480 ins; 8784 del; 10145 mod Patch: https://git.openjdk.org/jdk/pull/7445.diff Fetch: git fetch https://git.openjdk.org/jdk pull/7445/head:pull/7445 PR: https://git.openjdk.org/jdk/pull/7445
