[
https://issues.apache.org/jira/browse/HADOOP-19433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948181#comment-17948181
]
ASF GitHub Bot commented on HADOOP-19433:
-----------------------------------------
slfan1989 commented on code in PR #7586:
URL: https://github.com/apache/hadoop/pull/7586#discussion_r2066704498
##########
hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/mapred/tools/TestGetGroups.java:
##########
@@ -24,25 +24,26 @@
import org.apache.hadoop.mapred.tools.GetGroups;
import org.apache.hadoop.tools.GetGroupsTestBase;
import org.apache.hadoop.util.Tool;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Ignore;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
/**
* Tests for the MR implementation of {@link GetGroups}
*/
-@Ignore
+@Disabled
Review Comment:
@jojochuang Thank you very much for helping review the code! I agree to
remove this class.
@cnauroth Do you agree with doing this? This is indeed an old unit test and
is marked as Ignore.
> Upgrade JUnit from 4 to 5 in hadoop-extras.
> -------------------------------------------
>
> Key: HADOOP-19433
> URL: https://issues.apache.org/jira/browse/HADOOP-19433
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
