[
https://issues.apache.org/jira/browse/HADOOP-19433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947486#comment-17947486
]
ASF GitHub Bot commented on HADOOP-19433:
-----------------------------------------
slfan1989 commented on PR #7586:
URL: https://github.com/apache/hadoop/pull/7586#issuecomment-2831959261
> `TestGetGroups` ran tests in the base class `GetGroupsTestBase`, which
failed. Does JUnit 5 `@Disabled` not disable tests in superclasses? Would we
need to override each method and apply method-level `@Disabled` annotations?
@cnauroth Thank you for reviewing the code. Apologies for not noticing your
comment earlier, as I was focused on upgrading other modules to JUnit 5. I
believe your suggestion is correct, and I have made the necessary changes.
However, I noticed that the unit tests are still being executed. I suspect this
may be related to the fact that we are still in a mixed testing mode using both
JUnit 4 and JUnit 5.
> Upgrade JUnit from 4 to 5 in hadoop-extras.
> -------------------------------------------
>
> Key: HADOOP-19433
> URL: https://issues.apache.org/jira/browse/HADOOP-19433
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
