[ 
https://issues.apache.org/jira/browse/HADOOP-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875691#comment-17875691
 ] 

ASF GitHub Bot commented on HADOOP-19231:
-----------------------------------------

slfan1989 commented on PR #6953:
URL: https://github.com/apache/hadoop/pull/6953#issuecomment-2303356476

   > The failing tests run with hadoop-common 3.3.6 and the JacksonUtil is not 
in 3.3.6.
   > If we can't change the CI build to use hadoop-common 3.5.0-SNAPSHOT, we 
could clone JacksonUtil and add a copy of it to one of the yarn jars - and use 
that 2nd JacksonUtil class in the yarn code instead of the hadoop-common one.
   
   I found the error in the trunk branch, and it can be reproduced locally. I 
agree to roll back this pr, and then merge it after the unit test is completely 
passed. 




> add JacksonUtil to centralise some code
> ---------------------------------------
>
>                 Key: HADOOP-19231
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19231
>             Project: Hadoop Common
>          Issue Type: Task
>    Affects Versions: 3.4.0, 3.4.1
>            Reporter: PJ Fanning
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> To future proof Hadoop against Jackson changes, it makes sense to not just 
> create ObjectMappers and JsonFactories in many different places in the Hadoop 
> code.
> One of the main drivers of this is 
> https://www.javadoc.io/doc/com.fasterxml.jackson.core/jackson-core/latest/com/fasterxml/jackson/core/StreamReadConstraints.html
>  
> Jackson 3 (not yet scheduled for release) has some fairly big API and 
> behaviour changes too.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to