[ 
https://issues.apache.org/jira/browse/HADOOP-19231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875690#comment-17875690
 ] 

ASF GitHub Bot commented on HADOOP-19231:
-----------------------------------------

slfan1989 commented on PR #6953:
URL: https://github.com/apache/hadoop/pull/6953#issuecomment-2303349595

   @pjfanning  This pr brought some unit test errors.
   
   HBaseTimelineWriterImpl#testDomainIdTable
   
   ```
   java.lang.NoClassDefFoundError: org/apache/hadoop/util/JacksonUtil
   
        at 
org.apache.hadoop.yarn.util.timeline.TimelineUtils.<clinit>(TimelineUtils.java:57)
        at 
org.apache.hadoop.yarn.server.timelineservice.TimelineContext.<init>(TimelineContext.java:107)
        at 
org.apache.hadoop.yarn.server.timelineservice.collector.TimelineCollectorContext.<init>(TimelineCollectorContext.java:36)
        at 
org.apache.hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageDomain.testDomainIdTable(TestHBaseTimelineStorageDomain.java:65)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
        at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
        at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
        at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at 
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
        at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
        at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
        at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
        at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
        at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
        at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
        at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
        at 
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        at 
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
        at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
        at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
        at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
        at 
com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
        at 
com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
        at 
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
        at 
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232)
        at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)
   Caused by: java.lang.ClassNotFoundException: 
org.apache.hadoop.util.JacksonUtil
        at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
        ... 33 more
   
   ```
   
   cc: @steveloughran @ayushtkn 




> add JacksonUtil to centralise some code
> ---------------------------------------
>
>                 Key: HADOOP-19231
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19231
>             Project: Hadoop Common
>          Issue Type: Task
>    Affects Versions: 3.4.0, 3.4.1
>            Reporter: PJ Fanning
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.5.0
>
>
> To future proof Hadoop against Jackson changes, it makes sense to not just 
> create ObjectMappers and JsonFactories in many different places in the Hadoop 
> code.
> One of the main drivers of this is 
> https://www.javadoc.io/doc/com.fasterxml.jackson.core/jackson-core/latest/com/fasterxml/jackson/core/StreamReadConstraints.html
>  
> Jackson 3 (not yet scheduled for release) has some fairly big API and 
> behaviour changes too.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to