simbadzina commented on code in PR #6804:
URL: https://github.com/apache/hadoop/pull/6804#discussion_r1594952346
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/PoolAlignmentContext.java:
##########
@@ -64,7 +64,11 @@ public void
updateResponseState(RpcHeaderProtos.RpcResponseHeaderProto.Builder h
*/
@Override
public void receiveResponseState(RpcHeaderProtos.RpcResponseHeaderProto
header) {
- sharedGlobalStateId.accumulate(header.getStateId());
+ if (header.getStateId() == 0 && sharedGlobalStateId.get() > 0) {
Review Comment:
The tests in TestNoNamenodesAvailableLongTime rely on the router allowing a
stateId of 0. So having `sharedGlobalStateId.get() > 0` allows this behavior
which guarding against when the sharedGlobalStateId has advances beyond zero.
The tests in `TestNoNamenodesAvailableLongTime` do need to be fixed but I
would like to limit the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
